Hotfix/eslint config - Githubissues

guilhermebkel / uno-game

:flower_playing_cards: An UNO Game made in Javascript

https://uno.guilherr.me

MIT License

207 stars 59 forks source link

Hotfix/eslint config #9

Closed ArcaneDiver closed 3 years ago

ArcaneDiver commented 3 years ago

Hey 👋, i finally completed to set eslint config. I noticed that in unoenty package eslint was set only to use react-app rules then i extended even the root config and that generated a lots of errors and warnings. I added two new commands:

lint: runs eslint and shows every error and warning
lint:fix: runs eslint and try to fix errors (some errors/warning cannot be fixed)

Please feel free to write me for any clarification🤗.

guilhermebkel commented 3 years ago

Hello @ArcaneDiver! Thanks for creating the new rules. You said that erros/warnings appeared and maybe that's a good thing 😆 (because some time ago I started feeling like eslint was not working well on the packages haha).

I'll give a look on your commit soon! 😃

ArcaneDiver commented 3 years ago

Hey 👋,

I don't know why but i hadn't fixed some types. Anyways i fixed them and i also added some scripts in order to check types before commit.