"label" for profile settings checkbox - mouse click on/off does not work

guilhermenoronha / redmine_send_mails

2 stars 1 forks source link

"label" for profile settings checkbox - mouse click on/off does not work #5

Closed arnisjuraga closed 10 years ago

arnisjuraga commented 10 years ago

label must have the same name, as checkbox input ID, so - the mouse click on the label text will check/unckeck setting.

guilhermenoronha commented 10 years ago

Fixed, please check!

arnisjuraga commented 10 years ago

Now everything is even worse... :)

without plugin - label is working correctly:
with plugin - both labels "for" attribute differs from input "id" attribute: :

guilhermenoronha commented 10 years ago

I'm sorry but I didn't realize your problem. Has it some restriction to you use the plugin? If you can explain to me details of it... Thanks.

arnisjuraga commented 10 years ago

the problem is: after plugin installation, in user profile page you can set 2 checkboxes.

But - the "label" tag for these checkboxes ar incorrect. Usually - if you have "label" tag for checkbox input field - you can check/uncheck it by mouse click ON THE LABEL TEXT (see this print screen):

If the label is set incorrectly, then mouse click on the text does not work.

In previous print screen I show HTML source, where you can see, that ID and label FOR attributes are different. So - clicking on label text does not check/unckeck input checkboxes.

guilhermenoronha commented 10 years ago

Fixed. Once more thanks for feedback! If it don't fix your problem, please re-open the issue.

arnisjuraga commented 10 years ago

OK, I confirm that with:

git clone -b master https://github.com/guilhermenoronha/redmine_send_mails.git redmine_send_mails

now works! It seems, I have been cloning 2.3.x branch before?

guilhermenoronha commented 10 years ago

Yeah, I've merged the branch into the master. I'm not intending to use the branch 2.3.x for awhile.