search

guilhermerodz / input-otp

One time passcode Input. Accessible & unstyled.
https://input-otp.rodz.dev
MIT License
2.52k stars 53 forks source link

[BUG]: Form elements do not have associated labels - Accessibility issue on documentation #41

Closed withden closed 6 months ago

withden commented 7 months ago

Version of the library: 1.x

Current Behavior

Screenshot from 2024-04-08 08-32-23

Possible Solution

I'm working on it, I will probably create a PR request for it.

Steps to Reproduce

  1. Open the dev console (chrome or any browser).
  2. Do the lighthouse analysis
guilhermerodz commented 7 months ago

hi @withden that is not a bug with the library, it's definitely an accessibility issue on the website as I haven't created an <label htmlFor> for the input in the center of the landing page. but definitely not an issue on the library itself.

withden commented 7 months ago

Hey,

Yes, I just saw it. it's the only issue on the docs website. Can I make changes to the docs website?

By the way, great work done @guilhermerodz & thanks for creating OTP Input.

guilhermerodz commented 7 months ago

sure thing @withden make sure to keep the same current landing page appearance (spacing, etc). so no changes visually, while still addressing the missing <label htmlFor> issue. thank you so much!