guillaume-chevalier / seq2seq-signal-prediction

Signal forecasting with a Sequence-to-Sequence (seq2seq) Recurrent Neural Network (RNN) model in TensorFlow - Guillaume Chevalier
Apache License 2.0
1.08k stars 293 forks source link

Some ideas to improve this project #3

Open 0b01 opened 7 years ago

0b01 commented 7 years ago

I am a seq2seq beginner so these are just my 2 cents. Correct me if I'm wrong.

That's all.

0b01 commented 7 years ago
0b01 commented 7 years ago

https://github.com/guillaume-chevalier/seq2seq-signal-prediction/commit/1b1701386cb1e40ecde3b8e7a5e7ae08cc256b3b#commitcomment-22530082

0b01 commented 7 years ago

The error function should be mean absolute percentage error:

https://en.wikipedia.org/wiki/Mean_absolute_percentage_error

guillaume-chevalier commented 7 years ago

Hi @rickyhan,

I think your ideas are nice and that it would be worth trying! I really appreciate your suggestions. Here are my comments on that:

I'll create a CONTRIBUTING.md file right now for instructions on how to contribute, in case anyone is interested.

nicolapiccinelli commented 6 years ago

Give a solution for each exercise