Doesn't work with plank make [BUG]

[Moonbed1994]

Describe the bug The action progress bar does not appear when do the plank malke spell.

To Reproduce For me all I have too do is initiate the plank make spell.

Expected behavior I expect the progress bar to appear.

I've attempted to turn plugin on and off, uninstall/reinstall plugin, update windows, update runelite, restart pc but doesnt seem to help. All other skills seem to work though just not plank make.

[guillaume009]

@Moonbed1994 I have taken a look and I don't see anything wrong at first glance in the code. To help me figure it out, does the string jewellery spell make the bar appear? Interested to know since it's in the same spellbook.

Unfortunately I don't have the magic lvl to try the plank make spell, so your help will be needed for that

[liniim]

String Jewellery works, Plank Make doesnt. I'm making Teak Planks.

[liniim]

I found out that the bar shows up when I used a mahogany log on another mahogany log.

[Moonbed1994]

@guillaume009 as above, the progress bar will appear when using a plank on a log but of couse the action will stop.

[Moonbed1994]

I'd like to add that previously it has been working correctly but only in the last couple of weeks it has broken.

[guillaume009]

The magic spells were modified recently to combine the enchant spells into a new sub menu. I was thinking that this might explain why plank make doesn't work, because the code looks for the index of the spell in the list to execute the corresponding logic. However, it was confirmed that string jewellery works. This likely means that the issue is not there.

I am able to reproduce the problem of the action bar showing when a plank is double clicked or when one plank is clicked with another. This is a different problem than the fact that casting the spell doesn't trigger the action bar. If anything, the bar showing when clicking plank is a good sign, because it means the check for the requirements of the spell (runes + money) works.

Can you try looking at the runelite logs to see if there are any exception when casting plank make related to this plugin that could help me figure out where the issue is? You can access them here :

%userprofile%.runelite\logs

Here is an example of the debug logs when running the plugin locally. Those will not be available in the released version, but it should give you an idea

[druyang]

I think there's something wrong with the make plank detection: https://i.imgur.com/gsGAdVu.gif

[guillaume009]

@druyang Can you make a different bug for that? It's a different problem

[druyang]

@druyang Can you make a different bug for that? It's a different problem

Is it not related? In the second half of the gif, you can see that plank make does not work with the action detector.

You can reverse the order of the demonstration: When I use plank make on a plank: does not work. When I use a log on a log: plank make thinks it's making planks.

[guillaume009]

Yes, the two things are unrelated.

One can be fixed without the other being fixed

[druyang]

Looking at the code, I see what you mean. Thanks, I will open a PR shortly

[guillaume009]

Will be merged on runelite here

https://github.com/runelite/plugin-hub/pull/5944