search

guillaume009 / runelite-plugin-action-progress

BSD 2-Clause "Simplified" License
3 stars 7 forks source link

Plank Make Fixes: enhances target detection, fixes widget #62

Closed druyang closed 2 months ago

druyang commented 2 months ago
  1. Ensures that plank make is detected only when casting the spell. (Instead of widget on widget).
  2. Correct widget border type for casting plank make

Fixes:

Screenshot:

https://i.imgur.com/DSGkdWO.gif

Sidenote:

This is my first time working on a runelite plugin. I'm not 100% sure if this is the best way to do border detection.

druyang commented 2 months ago

I will say the border issue is quite interesting. The runelite docs say:

Returns the border type of item/sprite on the widget 0 - No border 1 - 1px black border 2 - 1px black under 1px white border (selected item)

it's interesting that 0 doesn't work here and that 2 does work here. I noticed that this previously was the opposite case. Perhaps jagex changed the selection engine. From my testing it's clear that 2 is working, and 0 is not.