guillaume009 / runelite-plugin-action-progress

BSD 2-Clause "Simplified" License
3 stars 8 forks source link

[BUG] Action Finished Notification Sometimes One Tick Early #63

Open coopermor opened 5 months ago

coopermor commented 5 months ago

I've noticed this when cooking but it may happen other places. I've noticed that sometimes the "Notify when finished" notification appears one tick early. This isn't just visual, if you walk away when the notification occurs you end up with one uncooked item. Attached are screenshots one frame apart where you can see the all items processed notification has occurred but there is one uncooked anglerfish in the inventory. 082 083

guillaume009 commented 5 months ago

Is the progress bar itself also disapearing one tick early?

Is it only with anglerfish?

Trying to figure out where the issue would be coming from. It can be that the calculation of the end time for cooking is off, or something else

coopermor commented 5 months ago

The progress bar also disappears which you can see in the second screenshot. I've had it happen with swordfish, sharks, and anglerfish. I imagine it happens with all fish and potentially all range items. It doesn't happen every time. I'd say about 1/10 inventories it finishes one tick early but the other 9/10 times it finishes at the correct time.