search

guillaumeaubert / Perl-Critic-Policy-ValuesAndExpressions-PreventSQLInjection

PerlCritic policy that attempts to detect the most common sources of SQL injection in manually crafted SQL statements, by detecting the use of variables inside interpolated strings that look like SQL statements.
https://metacpan.org/pod/Perl::Critic::Policy::ValuesAndExpressions::PreventSQLInjection
Other
6 stars 8 forks source link

Failing test - It seems that PPI has problems when heredoc terminator is... #17

Open vsespb opened 10 years ago

vsespb commented 10 years ago

... last in file and there is 0 or 1 newline after it (not more).

guillaumeaubert commented 10 years ago

I investigated the relevant PPI code and found the issue - the section of code that is designed to handle here-doc terminators without a trailing newline can never be reached due to a bug in the parsing loop. I sent a pull request to PPI's repository yesterday to address the issue: https://github.com/adamkennedy/PPI/pull/72.

I'm going to keep your pull request open until the underlying issue is addressed in PPI, and once that is done I will re-run your pull request against Travis to make sure that it is completely fixed.

oalders commented 3 years ago

I'm going to keep your pull request open until the underlying issue is addressed in PPI, and once that is done I will re-run your pull request against Travis to make sure that it is completely fixed.

That PR was merged and released in PPI 1.222 https://metacpan.org/changes/distribution/PPI#L162

oalders commented 3 years ago

With the latest PPI these tests are now passing, so I think this PR can safely be merged into master.