Closed cmey closed 2 years ago
Sorry for the late answer. Many thanks for the pull request and for taking care of following the guidelines !
Cheers, Guillaume
@guillaumeblanc Do you mind making a new release with this fix? maybe a minor version bump to 0.14.1 ? :pray:
Hi and thanks for this wonderful library! I'm proposing a fix for some compilation warnings.
Compiling with warning flag
-Wdeprecated-copy
(part of-Wextra
) produced this type of warning on clang and gcc:Easy steps to repro on
develop
:I saw 2 occurrences of the warning so there are 2 changes:
span.h
, where I've added the explicit default copy constructor (a copy operator was already implemented). It turns out the copy constructor is used, because explicitly disabling it with= delete
produces errors.intrusive_list_tests.cc
, where I've simply updated the disabling of the copy assignment operator to the more modern way. This way there no longer is a user-provided copy assignment operator, which appeases the warning.This clears the warnings reported above.
I've followed the Contributing guidelines:
clang-format
on the touched filesctest
passes locallyHope this helps!