guillaumeblanc / ozz-animation

Open source c++ skeletal animation library and toolset
http://guillaumeblanc.github.io/ozz-animation/
Other
2.46k stars 302 forks source link

Log adds a dependency on the standard C++ library for runtime #165

Closed PieroV closed 1 year ago

PieroV commented 1 year ago

README.md says:

The run-time code (ozz_base, ozz_animation, ozz_geometry) depends only on c++11, the standard CRT and has no OS specific code, portability to any other platform shouldn't be an issue.

So, it says nothing about the standard C++ library (I interpret the standard CRT as the standard C Runtime/libc). However, when compiling with GCC 12 on Linux, with the standard C++ library disabled, I obtain this error:

          /usr/include/c++/12/iostream:74: undefined reference to `std::ios_base::Init::Init()'
          /usr/bin/ld: /usr/include/c++/12/iostream:74: undefined reference to `std::ios_base::Init::~Init()'

I also get a few errors about operator delete not being defined, but I think I could do something about them (or just enable the standard C++ library for now).

guillaumeblanc commented 1 year ago

Hi,

thanks for reporting the issue. ozz depends on standard c++ library for sure.

How would you rephrase that sentence in the README? Could you propose a PR?

Cheers, Guillaume

PieroV commented 1 year ago

Hi,

thanks for reporting the issue. ozz depends on standard c++ library for sure.

How would you rephrase that sentence in the README? Could you propose a PR?

Cheers, Guillaume

Done!

Thanks!