Fix missing glfw linking option in samples for emscripten

guillaumeblanc / ozz-animation

Open source c++ skeletal animation library and toolset

http://guillaumeblanc.github.io/ozz-animation/

Other

2.46k stars 302 forks source link

Fix missing glfw linking option in samples for emscripten #171

Closed PhantomCloak closed 9 months ago

PhantomCloak commented 1 year ago

Summary

This PR resolves the issue where building samples for Emscripten failed due to GLFW not being linked in the linking stage. While users can circumvent this problem by manually adding -sUSE_GLFW=2, this workaround may not be obvious to all users. Therefore, integrating this flag into the existing samples eliminates the need for any manual flags in the Emscripten build process.

guillaumeblanc commented 9 months ago

Hi,

thanks for the PR !

I also encountered the issue indeed while adding wasm is part of the CI. It was fixed by adding the flag directly to the sample_framwork target. It avoids adding it to all executables.

Many thanks! Guillaume