search

guillaumeblanc / ozz-animation

Open source c++ skeletal animation library and toolset
http://guillaumeblanc.github.io/ozz-animation/
Other
2.46k stars 302 forks source link

make the dll_copy generated file a PRIVATE target_source #181

Open miguelibero opened 4 months ago

miguelibero commented 4 months ago

Hi, thanks for the excellent library! I tried to use it in my project with FetchContent but got an error when installing saying that the dll_copy target source is inside the binary dir. By changing it to PRIVATE it seems to work, but I'm no CMake expert so maybe this solution has other effects, but I couldn't find any. I think it's better explained here.

guillaumeblanc commented 3 months ago

Thanks for the PR!

Did you manage to test the fix?

I'm not used to FindContent. Can you see a way to implement a test? Maybe inspired by the existing test that ensure ozz can be used as a sub/external project?

Cheers, Guillaume

miguelibero commented 3 months ago

Can you see a way to implement a test? Maybe inspired by the existing test that ensure ozz can be used as a sub/external project?

great, I didn't know you had tests for CMake cases, I should be able to add one for FetchContent, yes.