search

guillaumeblanc / ozz-animation

Open source c++ skeletal animation library and toolset
http://guillaumeblanc.github.io/ozz-animation/
Other
2.46k stars 302 forks source link

LocalToModeJob support user-defined root matrix, see #46 #48

Closed cloudwu closed 6 years ago

cloudwu commented 6 years ago

I update the pr, Is it ok now ? Or should I move the EXPECT_FLOAT4x4_EQ into the scope ?

guillaumeblanc commented 6 years ago

I would usually have had the EXPECT_FLOAT.. inside the scope, to make it clear it's one test case. You can also declare ozz::math::Float4x4 output[6] in that scope.

Also, have you seen there's a warning in appveyor build: https://ci.appveyor.com/project/guillaumeblanc/ozz-animation/build/469/job/52dkwy1t11mtbnyq

C:\projects\ozz-animation\test\animation\runtime\local_to_model_job_tests.cc(160): warning C4456: declaration of 'root' hides previous local declaration

cloudwu commented 6 years ago

ok, I'll fix it. btw, I use mingw to build it, and gcc has different warnings from vc .

cloudwu commented 6 years ago

I put these into the scope. And mingw/gcc reports some other warnings for unit test. I create another pr to fix.

guillaumeblanc commented 6 years ago

Thanks for this great addition.