search

guillaumeblanc / ozz-animation

Open source c++ skeletal animation library and toolset
http://guillaumeblanc.github.io/ozz-animation/
Other
2.46k stars 302 forks source link

[cmake] add ozz_build_dump2ozz #92

Closed irov closed 4 years ago

irov commented 4 years ago

Hello, my CI for android or ios break on build executable library dump2ozz please add option like 'ozz_build_fbx'

Thanks!

guillaumeblanc commented 4 years ago

Interesting.

I think ozz_build_tools should do the job, but apparently it only deactivates fbx2ozz and gltf2ozz tools, not dump2ozz. It should even disables ozz_animation_tools. What do you think?

Also could you provide a link to your CI if it's public. I'm interested in seing the error, and also I'd be glad to have those CI targets for ozz CI if possible.

Thanks, Guillaume

irov commented 4 years ago

I think ozz_build_tools should do the job, but apparently it only deactivates fbx2ozz and gltf2ozz tools, not dump2ozz. It should even disables ozz_animation_tools. What do you think?

If this does not affect compile other libraries, then I think you can. I remove only build dump2ozz.

Also could you provide a link to your CI if it's public. I'm interested in seing the error, and also I'd be glad to have those CI targets for ozz CI if possible.

I am setting it up now and the story is lost there. There the assembly goes on IOS, and build executable without MACOSX_BUNDLE will not work. And I think it is not necessary.

Thanks!

guillaumeblanc commented 4 years ago

With ozz_build_tools option, I assume ozz_animation_tools lib should be disabled as well.

guillaumeblanc commented 4 years ago

Seems 23b3a2a does the job: https://travis-ci.org/github/guillaumeblanc/ozz-animation/jobs/677842367. Any feedback?

I didn't get what CD/CI platforms you were using?

irov commented 4 years ago

I didn't get what CD/CI platforms you were using?

I use Travis CI, and IOS toolchains

guillaumeblanc commented 4 years ago

ozz_build_tools fix is submitted.

I never compiled for ios, so I'd be very happy to have your feedback if something needs to be fixed. Would be even more awesome if your findings on making CI work on iOS could get back into ozz via a PR ;) !

irov commented 4 years ago

I never compiled for ios, so I'd be very happy to have your feedback if something needs to be fixed. Would be even more awesome if your findings on making CI work on iOS could get back into ozz via a PR ;) !

  # iOS
  - os: osx
    osx_image: xcode10
    compiler: clang
    env:
    - env_cmake_system=iOS

and add -DCMAKE_SYSTEM_NAME=$env_cmake_system

and you get many issue for tools and other settings

guillaumeblanc commented 4 years ago

Closing as initial request is fixed.