Refactor/ansible - Githubissues

guillaumebriday / kamal-ansible-manager

Manage and optimize your servers automatically for Kamal with Ansible

MIT License

145 stars 19 forks source link

Refactor/ansible #6

Closed pythoninthegrass closed 21 hours ago

pythoninthegrass commented 1 month ago

Hi @guillaumebriday! Appreciate your work on this!

Made some admittedly opinionated changes — although most of them come from linting and ansible norms — that I thought you might appreciate.

Happy to expand on the following, but these are the high-level modifications:

docs

readme: remove non-root $ prefixes, add ansible.cfg.example, fix typo
ansible.cfg.example: rename to hosts.ini to match upstream
hosts.ini.example: add all config for localhost and vars, move become method and user to vars

refactor

add become to playbook for non-root sudoers
FQCNs (builtin vs. community)
fix docker gpg key (keyrings directory, implicit octal notation)
tags (selectively run roles)
add ansible.cfg.example w/facts directory placeholder
add .ansible-lint
update .gitignore

guillaumebriday commented 21 hours ago

Please rebase the branch if you still want to submit changes in this PR 🙏

Closing in the meantime, feel free to reopen