guillaumebriday / laravel-blog

Laravel 11.0 blog application with Hotwire, Horizon, Telescope, Sanctum, Breeze and Pusher
https://laravel-blog.guillaumebriday.fr
MIT License
1.75k stars 572 forks source link

If the locale is not French, the test will fail. #15

Closed ivoth closed 6 years ago

ivoth commented 6 years ago

Some of the tests are fixed French.

guillaumebriday commented 6 years ago

Hey ! I will fix that. In the next release the default language will be English 👍

ivoth commented 6 years ago

Can use localized languages in tests? Also, can the default account be added to the configuration? Thanks

guillaumebriday commented 6 years ago

🤔 I don't think it's a good practice because if a key is not defined the tests will be green anyway.

I want to tests the complete response. I'm going to translate the tests in a next PR. 👍

guillaumebriday commented 6 years ago

Fixed : https://github.com/guillaumebriday/laravel-blog/commit/4a7d67d836a96a65136d51b3f34096a6a95f42ec