Selection fix for when different panes are set

guillaumechereau / goxel

Goxel: Free and Open Source 3D Voxel Editor

GNU General Public License v3.0

2.8k stars 223 forks source link

Selection fix for when different panes are set #156

Closed ntfwc closed 5 years ago

ntfwc commented 5 years ago

I noticed that when a different pane is set, selection stops working correctly. It is not correctly determining the selection box dimensions and even introduces negative sizes. This pull request fixes the behavior to be consistent when different planes are set.

ntfwc commented 5 years ago

Ah, I see I haven't quite met the contributing document requirements. I will fix that.

guillaumechereau commented 5 years ago

Thanks. I am a bit busy with other things these days so I haven't checked this yet. I'll have a look soon.

guillaumechereau commented 5 years ago

I finally got to check this issue. Sorry for the delay. The fix seems to work, thanks!

This issue makes me think that the whole box editing used in many part of the code needs a big cleanup... At some point I'll try to have a look at that.

ntfwc commented 5 years ago

No problem. I'm glad I could help.