Allow to use distribution libraries for inih, imgui, xxhash, etc

guillaumechereau / goxel

Goxel: Free and Open Source 3D Voxel Editor

GNU General Public License v3.0

2.8k stars 223 forks source link

Allow to use distribution libraries for inih, imgui, xxhash, etc #184

Open stephanlachnit opened 4 years ago

stephanlachnit commented 4 years ago

inih now got a pkg-config entry in version 48, so it would be nice if users (especially distros) could optionally link against it instead of compiling it. I would do a PR, but I don't know anything about the SCons build system.

guillaumechereau commented 4 years ago

This is possible yes, but is that really worth it though? inih is such a small library, I don't think the compiled code size is significant. Also, there are some compile time options of inih that are set in goxel that might not be the default on all distributions.

FedericoCeratto commented 4 years ago

@guillaumechereau Goxel bundles a lot of dependencies: imgui inih lua noc stb xxhash yocto Bundling the same libraries in different applications creates a lot of additional work for distributions (e.g. when backporting and testing security updates).