search

guillaumechereau / goxel

Goxel: Free and Open Source 3D Voxel Editor
GNU General Public License v3.0
2.83k stars 226 forks source link

Goxel crashes when saving if there's a selection #291

Closed ghost closed 1 year ago

ghost commented 2 years ago

When the selection tool is active and some blocks are selected, if I attempt to save the file goxel crashes every single time without fault. Fun part tho: it still saves the progress correctly, so that's nice, except for having to restart. This issue might be related to https://github.com/guillaumechereau/goxel/issues/211 but since it's very specific it might differ.

Goxel version: 0.10.8 OS: Latest ubuntu, all updates.

Side note: goxel is actually fun to use.

guillaumechereau commented 2 years ago

Thanks for the report. I'll have a look at this.

ghost commented 2 years ago

Also, this was specifically for a VXL file, might be important I don't know. @guillaumechereau

guillaumechereau commented 2 years ago

You mean it only crashes when you try to export as VXL? If so do you have an example of faulty model I could look at?

ghost commented 2 years ago

@guillaumechereau I mean I only tested it with a VXL export, not another format. But I suspect https://github.com/guillaumechereau/goxel/commit/40ce8ebc099c5b50253088f675572e781dafd6e2 was your fix for this or?

guillaumechereau commented 1 year ago

Yes I think! I will close this for now because I cannot reproduce the bug. Feel free to reopen if needed.

OneArb commented 1 year ago

I can reproduce the issue on 0.11.0 - Arch Linux

with a selection

  saving using menu (mouse) works
  saving using shortcut

(goxel:1786178): Gtk-WARNING **: 14:39:17.531: Theme parsing error: gtk.css:9672:21: Not using units is deprecated. Assuming 'px'. 0.000: Save to /home/arch/Documents/voxel/goxel/catatonia debug/catatonia03.gox save_to_file (src/formats/gox.c:259) 0.033: Saved /home/arch/Documents/voxel/goxel/catatonia debug/catatonia03.gox sys_on_saved (src/system.c:295) Segmentation fault (core dumped)

"Not using units is deprecated. Assuming 'px'" can be seen when saving, but not if just using goxel exiting with saving.

Also Crtl Z shortcut is not working. Undoing through the menu works.