guillaumechereau / goxel

Goxel: Free and Open Source 3D Voxel Editor
GNU General Public License v3.0
2.83k stars 226 forks source link

[Bug] Selection Tool not Obeying Size #384

Closed 420noscope-exe closed 3 months ago

420noscope-exe commented 3 months ago
lsb_release -a                                                  
LSB Version:    n/a
Distributor ID: ManjaroLinux
Description:    Manjaro Linux
Release:    24.0.4
Codename:   Wynsdey

uname -r                                                        
6.6.40-1-MANJARO

Using ci Action #417 AppImage.

Expected Behavior: The selection tool selects all voxels within its box. The size (dimensions) and origin of the box can be set in the tool window.

Observed Behavior: The selection tool will erroneously ignore voxels within the box, and select voxels outside of the box.

I tried selecting the face of this layer with a h value of 1. Screenshot from 2024-07-28 21-37-25

It selected a strange shape, the top half had an h value of 4, the bottom had a value of 1. Screenshot from 2024-07-28 21-37-40

This is what it looks like after I cut it to a new layer and set the visibility to off. Screenshot from 2024-07-28 21-38-01

Another selection test. h is set to 4. Looks good (Except for the bottom): Screenshot from 2024-07-28 21-39-11

When increased to 5, it breaks: Screenshot from 2024-07-28 21-39-23

guillaumechereau commented 3 months ago

Thanks! I just pushed a fix, hopefully this doesn't break anything else.

420noscope-exe commented 3 months ago

This fixed it! Thanks!