search

guillaumedsde / alpine-qbittorrent-openvpn

qBittorrent docker container with OpenVPN client running as unprivileged user on alpine linux
https://guillaumedsde.gitlab.io/alpine-qbittorrent-openvpn/
GNU General Public License v3.0
216 stars 40 forks source link

Support multiple docker networks #109

Closed mwean closed 2 years ago

mwean commented 2 years ago

The iptables script currently assumes a single docker network, which it creates rules for. But if there are multiple, the DOCKER_CIDR variable will have newline-separated ips, which breaks the iptables rules. It turns out that iptables will accept comma-separated ips, so we just need to join all the extracted ips with a comma.

guillaumedsde commented 2 years ago

thanks for the contribution, I'll look this over after the holidays

guillaumedsde commented 2 years ago

Thanks again for the contribution, I've merged these changes into the development branch, I'll merge them into master in a week or so (in the meantime the changes will be available in the development tagged image)

guillaumedsde commented 2 years ago

Good evening, sorry I've not been very responsive on this, I've struggled with my git rebase so github doesn't recognize this PR as merged (the rebase modified some commits due to conflicts) so I'm closing it because it is merged ( see commit 5ad0606c0e5af37cc1902a28225119727615f980 )

thanks again for the contribution, I'll make sure to rebase correctly next time so github shows this PR as merged instead of closed