Closed ezruneko closed 2 years ago
done!
apologies again for the delay, I'll look this over after the holidays
Thanks again for the contribution, I've merged these changes into the development branch, I'll merge them into master in a week or so (in the meantime the changes will be available in the development tagged image)
@guillaumedsde can this be merged into master? can't use NordVPN without it
Thanks again for the contribution, I've merged these changes into the development branch, I'll merge them into master in a week or so (in the meantime the changes will be available in the development tagged image)
Any update on this? I can use the development branch fine, but since the python branch is separate, I don't have a functional search bar.
Update?
Good evening, sorry I've not been very responsive on this, the change has been merged into master, I'll make sure the python based image is also built for the development branch in the future
I've struggled with my git rebase so github doesn't recognize this PR as merged (the rebase modified some commits due to conflicts) so I'm closing it because it is merged (see commits 17c9540d24cd71b584c50381daaaf5fd7d3e05f5 )
thanks again for the contribution, I'll make sure to rebase correctly next time so github shows this PR as merged instead of closed
Hi, sorry for the delayed reply, I've commented on some minor points, running the script with bash should solve the issue indeed, nicely spotted