guillaumegenthial / tf_ner

Simple and Efficient Tensorflow implementations of NER models with tf.estimator and tf.data
Apache License 2.0
924 stars 275 forks source link

fix glove path #4

Closed alifejon closed 5 years ago

cassianojaeger commented 6 years ago

Verified and it is working fine. A folder with the same name is generated with the file inside.

guillaumegenthial commented 5 years ago

Hey @cassianojaeger,

Thanks for contributing.

There might be an issue with the make file, but I don't think that 'glove.840B.300d.txt/glove.840B.300d.txt' is the right way to go!

Could you describe the issue in more details?

mossaab0 commented 5 years ago

@guillaumegenthial On Windows 10 / WSL / Ubuntu 18.04, the uncompressed file is located at glove.840B.300d.txt/glove.840B.300d.txt. I didn't try a different system configuration. I suspect this is the issue the PR tries to solve.