Add support for history v5 and react-router-dom v6

guillaumeparis2000 / react-piwik

Library that allow to connect piwik with the react-router and track custom events

31 stars 17 forks source link

Add support for history v5 and react-router-dom v6 #32

Closed evelynhathaway closed 4 years ago

evelynhathaway commented 4 years ago

[ ] Create a branch for the call signature for the history.listen() callback in history v5 and react-router-dom v6
[ ] Fix any issues with location objects in track()
[ ] Add History5 type for the new call signature and test types

_Originally referenced by @evelynhathaway in https://github.com/guillaumeparis2000/react-piwik/pull/31#discussion_r487456860_

guillaumeparis2000 commented 4 years ago

Thanks for the fix, published in version v1.9.0

evelynhathaway commented 4 years ago

I didn't fix the compatibility issue in the typings MR. I left this open as future work. It should be an easy issue to take on for someone during Hacktoberfest. ☺️