search

guillaumepotier / Parsley.js

Validate your forms, frontend, without writing a single line of javascript
http://parsleyjs.org
MIT License
9.05k stars 1.32k forks source link

Remove deprecated deferred.pipe() #1347

Open partiellkorrekt opened 3 years ago

partiellkorrekt commented 3 years ago

As demonstrated by https://github.com/guillaumepotier/Parsley.js/issues/1226, Parsley.js still uses the deprecated function deferred.pipe

There has been a fix before: https://github.com/guillaumepotier/Parsley.js/pull/1253 That fix has been retracted because it doesn't pass the test suite. This fix removes deferred.pipe and still passes all the tests.

marcandre commented 3 years ago

This is ready to merge 👍, but looks like the build is broken (again 😭). I'm sorry I'm not sure when I'll have time to look at that.

amalmk commented 3 years ago

@marcandre Hey, can you please check this PR once again? I am also waiting for this change ;)