search

guillaumepotier / Parsley.js

Validate your forms, frontend, without writing a single line of javascript
http://parsleyjs.org
MIT License
9.04k stars 1.31k forks source link

Feature Request: allow customizing "filled" class in config #820

Open timkelty opened 9 years ago

guillaumepotier commented 9 years ago

Why not ?

Looking at that .filled class, it feels not homogeneous with .parlsey-error and .parsley-success.

Might we use the upcoming 2.1 release to make this class customizable and by default .parsley-filled?

marcandre commented 9 years ago

I'm starting to think we might as well not keep the empty wrappers around.

They are generated lazily now, and the current error removal can create issues when it's not a simple container, so maybe it's better to altogether remove them if they're emptied?

In other words, the filled class could become obsolete; all wrappers are always filled, otherwise they're removed. We'd keep adding the filled class for 2.x, but in 3.0 they'd be gone.

Even simpler than having a preference for a class that's not really needed.

dcalhoun commented 7 years ago

The ability to customize all Parsley state classes would be nice. Specifically, I'd like to configure Parsley to use naming conventions that are already in our my source (e.g. SuitCSS, BEM, etc).

In other words, rather than...

<input class="TextField parsley-error" />

...I'd like to be able to have Parsley output...

<input class="TextField is-errored" />

...to match the SuitCSS naming patterns in my source.

marcandre commented 7 years ago

PR welcome :-) Default should probably be null, in which case the class is then computed from the namespace option.