search

guillaumepotier / gettext.js

gettext.js is a lightweight yet complete and accurate GNU gettext port for node and the browser.
http://guillaumepotier.github.io/gettext.js
150 stars 48 forks source link

Update po2json dep to latest available beta version #61

Closed whiteinge closed 2 years ago

whiteinge commented 2 years ago

This fixes a long-standing npm audit failure. This is for a beta version but upstream has been waiting on a stable release for a while now.

As an alternate approach: what do you think about removing the po2json dependency completely? Instead just link to that repo in the README (similar to what #38 is proposing). I'm fuzzy on what the value-add of the bin/po2json wrapper script is, and we just call out to po2json directly. That removal would make gettext.js a zero-dependency library with a stable API and with no now (or future!) NPM drama :stuck_out_tongue_closed_eyes: ).

guillaumepotier commented 2 years ago

Hi @whiteinge

Thank you for your PR, much appreciated :)

I'll think about the po2json removal, and make it optional eventually.

Best

whiteinge commented 2 years ago

@guillaumepotier would you mind cutting a new release with the recent PR merges?