search

guillaumezin / nvidiabl

/!\ Please note that I don't maintain this repository anymore, please have a look at forked projects. /!\
82 stars 82 forks source link

Adds G75VW to nvidiabl-laptops.h, adds "get" command for nvidiablctl #65

Closed DavidEGrayson closed 11 years ago

DavidEGrayson commented 11 years ago

Thanks for making this module! It worked for me. This is my first pull request.

First, it adds the ASUS G75VW gaming laptop to the list in nvidiabl-laptops.h. That line is based on the hardware info for my laptop which you can see here: https://gist.github.com/4301964

Secondly, I added a minor feature to nvidiablctl, which is "get" command for getting the brightness. As soon as I got brightness control working, I wanted the "get" command so I can see the details of what is happening.

Third, I fixed a minor typo in an error message in nvidiablctl.

Finally, I have a question: The nvdiablctl script works great for me, but my backlight function keys do not work. I have an AUS G75VW-DH72. Both function keys produce the same output in acpi_listen; both produce the following line:

PNP0C14:00 000000ff 00000000

Since they both produce the same output, I don't think I can use acpi events to get the hotkeys working. I was able to get the hotkeys working by using the propritary nvidia driver and setting the appropriate options, but I would like the backlight hotkeys to work under nouveau. Any advice on that? What is the basic block diagram for how the backlight hotkeys are supposed to work? Thanks!

DavidEGrayson commented 11 years ago

Hey, I see it's been 13 days. I hope you can pull in my branch some time because I do believe it represents an improvement to nvidiabl. Thanks! --David

badosu commented 11 years ago

I was already implementing this pull request until I remembered to check the already existing ones...

:+1: for this!