search

guillochon / MOSFiT

Modular Open Source Fitter for Transients
http://mosfit.readthedocs.io/
MIT License
42 stars 55 forks source link

(small bug) when running csmni - incorrect qoutation marks #216

Closed Astro-Sean closed 1 year ago

Astro-Sean commented 1 year ago

Hi all,

I ran into a issue when running a csmni model.

Line ~103 of csmni.json is currently (Mosfit v1.1.9):

    "kinetic_energy":{
        "kind":"parameter",
        "value":1.0,
        "class":"parameter",
        "latex":“E_{\\rm k}\\,(10^{51}\\,{\\rm erg})” # <- this line has incorrect quotation marks
    },

whereas it should be 

    "kinetic_energy":{
        "kind":"parameter",
        "value":1.0,
        "class":"parameter",
        "latex":"E_{\\rm k}\\,(10^{51}\\,{\\rm erg})" 
    },

Correcting this line allows the code to run on my machine with Python 3.9.13

All the best,

Sean

mnicholl commented 1 year ago

Thanks Sean, can you submit a pull request for this and I’ll merge it?

On 28 Nov 2022, at 07:32, Seán Brennan @.***> wrote:

Hi all,

I ran into a issue when running a csmni model.

Line ~103 of csmni.json is currently (Mosfit v1.1.9):

"kinetic_energy":{
    "kind":"parameter",
    "value":1.0,
    "class":"parameter",
    "latex":“E_{\\rm k}\\,(10^{51}\\,{\\rm erg})” # <- this line has incorrect quotation marks
},

whereas it should be

"kinetic_energy":{
    "kind":"parameter",
    "value":1.0,
    "class":"parameter",
    "latex":"E_{\\rm k}\\,(10^{51}\\,{\\rm erg})" 
},

Correcting this line allows the code to run on my machine with Python 3.9.13

All the best,

Sean

— Reply to this email directly, view it on GitHub https://github.com/guillochon/MOSFiT/issues/216, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZ74QX527IW24FVFQST6PLWKRN2JANCNFSM6AAAAAASNAMFRI. You are receiving this because you are subscribed to this thread.