search

guillochon / MOSFiT

Modular Open Source Fitter for Transients
http://mosfit.readthedocs.io/
MIT License
41 stars 53 forks source link

csm_table.dat columns inconsistency #226

Open navii98 opened 1 year ago

navii98 commented 1 year ago

In the info file along with the csm_table.dat the columns are defined as follows Columns are: n, s, beta_fs, beta_rs, A https://github.com/guillochon/MOSFiT/blob/7e7779b6932955eb3875ebab5fe3fd28745eeb17/mosfit/models/csm/data/info.txt#L1C1-L3C39

which is what the csm.py engine file expects https://github.com/guillochon/MOSFiT/blob/7e7779b6932955eb3875ebab5fe3fd28745eeb17/mosfit/modules/engines/csm.py#L37C1-L44C38

But looking at the csm_table.dat file, it seems like the first columns is representing s as it's value is varying from 0-2, and the second column varying from 6-14 is 'n' https://github.com/guillochon/MOSFiT/blob/7e7779b6932955eb3875ebab5fe3fd28745eeb17/mosfit/models/csm/data/csm_table.dat

mnicholl commented 11 months ago

I thought I had commented on this but looks like I didn't!

I agree that it looks like the columns are the wrong way round. I think it doesn't cause a problem for the model because another typo cancels it out: in csm.py, the n and s swaps again between lines 47-49 and 77-79.

@villrv could you check this and fix if needed? Thanks!