search

guiqui / react-timeline-gantt

A react Timeline component with virtual rendering
MIT License
544 stars 132 forks source link

Moment to date-fns #50

Closed Domino987 closed 4 years ago

Domino987 commented 4 years ago

This PR removes the largest dependency (moment) for the much smaller date-fns lib (74% smaller).

Not does this only decreases the bundle size of the whole project, since moments makes up 90% of this library dependencies, date-fns is also immutable which reduces possible errors.

I hope you like it.

guiqui commented 4 years ago

Nice, great to see the lib going down in size. I forgot how big it is moment js! Just merged into master, Thank you!

Domino987 commented 4 years ago

I do not see it in master. Can you check if you merged it correctly?