search

guitar-academy / gaserver

Server for Guitar Academy written in Python
0 stars 0 forks source link

API Setup #5

Closed andhieka closed 9 years ago

andhieka commented 9 years ago
andhieka commented 9 years ago

Thank you for the comments, Eugene. Will resolve them later.

digawp commented 9 years ago

Next time divide things into smaller PRs if possible, It is rather difficult to review this way. Atau ini memang masih preparing flask project structure?

9gix commented 9 years ago

Noted. This PR does too many stuff.

Another feedback specifically for commit https://github.com/guitar-academy/gaserver/commit/6ace6643fc48b6295c0f918048bff158d058ab6b is to break it down into multiple commit, because it deals with update index, API views, servername update, migrations, business logic. You can squash them into one commit only if they are related. E.g. adding API views can be squashed with adding application logic, but not with index, migrations, or servername.

Yet another feedback, don't forget to use topical branch naming convention. e.g. feature/database