search

guitarrapc / GraniResource

PowerShell Desired State Configuration Resources for real production workload.
https://www.powershellgallery.com/packages/GraniResource
MIT License
44 stars 8 forks source link

Update Grani_Download to support new TLS versions #84

Closed rajbos closed 6 years ago

rajbos commented 6 years ago

File: GraniResource/DSCResources/Grani_Download/Grani_Download.psm1

Ran into an issue in an ARM template where this resource was used. See here.

Fixed it by setting the TLS version before the download:

[System.Net.ServicePointManager]::SecurityProtocol = [System.Net.SecurityProtocolType]::Tls12 -bor [System.Net.SecurityProtocolType]::Tls11 -bor [System.Net.SecurityProtocolType]::Tls

I suggest we add that here as well, to prevent any issues when the host disables older TLS versions.

If you want, I can sent it in as a pull request, but thought it would be nice to open up an issue first.

guitarrapc commented 6 years ago

Wonderful, I forgot to set it for Resources. Thank you. Pull Request is always welcome:) If you can wait, I will patch tonight.

guitarrapc commented 6 years ago

Will release to gallery as soon as I home. (now i'm at mac environment.)

rajbos commented 6 years ago

No rush, fix is already present where I needed it, happy to contribute 👍 .

guitarrapc commented 6 years ago

released:) https://www.powershellgallery.com/packages/GraniResource/3.7.11.0 https://github.com/guitarrapc/GraniResource/releases/tag/ver.3.7.11.0