feat: add a parameter "clone_options"

guitarrapc / git-shallow-clone-orb

circleci orb to execute git shallow clone for faster checkout.

https://circleci.com/orbs/registry/orb/guitarrapc/git-shallow-clone

MIT License

21 stars 11 forks source link

feat: add a parameter "clone_options" #10

Closed suzuki-shunsuke closed 4 years ago

suzuki-shunsuke commented 4 years ago

issue: https://github.com/guitarrapc/git-shallow-clone-orb/issues/9

suzuki-shunsuke commented 4 years ago

https://circleci.com/gh/guitarrapc/git-shallow-clone-orb/294?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-checks-link

circleci orb publish workspace/orb.yml guitarrapc/git-shallow-clone@dev:alpha --token $CIRCLE_TOKEN 

Error: flag needs an argument: --token

Exited with code exit status 255

In the project settting, the environment variable CIRCLE_TOKEN should be set.

Or if the environment variable CIRCLECI_CLI_TOKEN is set, we can omit the argument --token.

guitarrapc commented 4 years ago

sorry about bothering with CI. No it isn't CIRCLE_TOKEN issue, I'm not turn-on Pass secrets to builds from forked pull requests options, so that circleci publish never works and it is intended to be.

I've modified fork pr will not trigger such job. please update your branch with latest upstream master.

suzuki-shunsuke commented 4 years ago

Oh, I see. Thank you.

I rebased, but unfortunately the same error was reproduced. 🤔

suzuki-shunsuke commented 4 years ago

We have to update the filter of the job orb-tools/publish-dev

https://github.com/guitarrapc/git-shallow-clone-orb/blob/352f8c8c2ca05a97f9c50d397d54381f00de4e52/.circleci/config.yml#L53-L56

suzuki-shunsuke commented 4 years ago

BTW, I saw the ignore pattern at the first time.

https://github.com/guitarrapc/git-shallow-clone-orb/blob/352f8c8c2ca05a97f9c50d397d54381f00de4e52/.circleci/config.yml#L65

Does it match pull requests?

suzuki-shunsuke commented 4 years ago

Oh, sorry. I understood. https://github.com/guitarrapc/git-shallow-clone-orb/pull/10#issuecomment-602043241

guitarrapc commented 4 years ago

I rebased, but unfortunately the same error was reproduced. 🤔

seems you won't merge upstream but commit directly to your branch? could you merge upstream/master to your branch?

suzuki-shunsuke commented 4 years ago

Please see the history. https://github.com/suzuki-shunsuke/git-shallow-clone-orb/commits/feat/support-shallow-since

And I fixed the problem. https://github.com/guitarrapc/git-shallow-clone-orb/pull/10/commits/944b2f9b72b7ef8d19967dd0a81e31bb39f62ab6

suzuki-shunsuke commented 4 years ago

I did

$ git fetch upstream
$ git rebase upstream/master
$ git push origin feat/support-shallow-since --force

guitarrapc commented 4 years ago

thanks!

guitarrapc commented 4 years ago

Thank you for the great contribution!

suzuki-shunsuke commented 4 years ago

Thank you for your quick work!