guitarrapc / git-shallow-clone-orb

circleci orb to execute git shallow clone for faster checkout.
https://circleci.com/orbs/registry/orb/guitarrapc/git-shallow-clone
MIT License
21 stars 11 forks source link

Add macOS support #18

Closed ankushg closed 2 years ago

ankushg commented 2 years ago

I tried this orb in a macOS executor and it hangs while trying to cat $CHECKOUT_KEY

When I connected via SSH, I could reproduce the hang when manually running cat $CHECKOUT_KEY, but things were fine when running echo instead

I'm not sure how to validate that this fixes everything though 😅

In this PR

ankushg commented 2 years ago

@guitarrapc I'm not sure if there's any way for external contributors to run integration tests, or cut an alpha build, but would love to see if this works for my macOS instance 😄

We were previously using https://github.com/vsco/advanced-checkout-orb (which worked for us on macOS!) but your fetch_options is exactly what we need

guitarrapc commented 2 years ago

@ankushg Thank you for your contributions.

I'm not sure if there's any way for external contributors to run integration tests, or cut an alpha build, but would love to see if this works for my macOS instance

I also don't know how to release alpha with external contribution 🤣 However code seems correct and perhaps work on both linux and macOS.

Let me merge you PR and I will do test.

guitarrapc commented 2 years ago

OK, it seems like I need get support with CircleCI to run orb test on macOS #19.

However Linux seems ok and vsco/advanced-checkout-orb also uses echo instead of cat, let's publish orb.

guitarrapc commented 2 years ago

@ankushg I've released orb v2.3.0. Please try it.

https://circleci.com/developer/orbs/orb/guitarrapc/git-shallow-clone?version=2.3.0

note: As of pipeline issue, I've disabled macOS integration test until CirrcleCI gives OSS offer, will enable it right after then.

guitarrapc commented 2 years ago

Re-enabled macOS test on #22, thanks.