search

guitcastro / codecov-android

Step to integrate codecov into your bitrise workflow
MIT License
1 stars 0 forks source link

Can we remove this step from https://github.com/bitrise-io/bitrise-steplib ? #2

Open viktorbenei opened 7 years ago

viktorbenei commented 7 years ago

Hi @guitcastro

Would you mind if we'd remove this step from the Bitrise Steplib? The https://github.com/bitrise-io/steps-codecov should now cover every project type, including android -> we worked with the codecov guys to figure out a way which works for both parties, the bitrise-io version of the step is as simple as: https://github.com/bitrise-io/steps-codecov/blob/master/step.sh - the official codecov integration script (https://codecov.io/bash) can now auto detect everything required.

We'd like to remove your version because it's a bit confusing to see two almost identical steps in the StepLib - but if you have anything against removing it from the step lib just let us know!

Thanks!

guitcastro commented 7 years ago

No problem, fell free to remove it. Glad to know that now we a have an official step ;)

viktorbenei commented 7 years ago

Awesome, and thanks again for your step, I'm sure it helped a lot while we were trying to figure out a way to have a unified step.

BTW we're thinking about moving the codecov step into the https://github.com/bitrise-community org - would you want to join https://github.com/bitrise-community , so that you can e.g. code review the step? (more info here: https://discuss.bitrise.io/t/bitrise-steps-community/496 )