search

guiwitz / napari-sediment

https://guiwitz.github.io/napari-sediment/napari_sediment.html
BSD 3-Clause "New" or "Revised" License
0 stars 1 forks source link

ROI #8

Open Epta13 opened 5 months ago

Epta13 commented 5 months ago

The default main and the small ROIs have wierd size - thin and wide, probably wrong coordinates or so.

guiwitz commented 5 months ago

The main roi should encompass the largest possible region given the current mask. It can be that there's something wrong with your mask as there seems to be an issue with it as well in #9. Maybe you can try to make a very simple mask (annotation a few places manually) to check that thing work?

Epta13 commented 5 months ago

Yes, I think it's the border mask which is not generated correctly. Once the mask is correct, the ROI works fine. One small adjustment would be to automatically adjust th length of the samll ROI to the main ROI. E.g., I create the main ROI, adjust the size as I need and then I wanna create smal ROI, but now it creates them in the same extend as the original main ROI. Would it be possible to read the main ROI size for creating the smal ROI?

guiwitz commented 5 months ago

This is actually already the expected behaviour so I'm not sure why you don't see it. For example in this example, the main roi discards some top and bottom rows, and when I add a small roi it fits inside the main roi. I'll have to investigate live. image

Epta13 commented 2 months ago

Is it possible that the small ROI will always take the height of the main ROI instead of the border mask?

guiwitz commented 2 months ago

Currently, the main row boundaries in mainroi_min_row etc. is not updated when manually changing the main roi. When adding the small roi, the old boundaries are therefore used. This should be fixed by updating when changing the main roi.