gujjwal00 / avnc

VNC Client for Android
GNU General Public License v3.0
602 stars 57 forks source link

Feature request: Align to top #145

Closed meeuw closed 1 year ago

meeuw commented 1 year ago

I'm using AVNC to control a persistent chrome desktop browser from my phone (useful for web apps that won't work on mobile browsers).

For this I'm running a vncserver on Linux with a low resolution matching my phone (540x600).

All works well with one small nuisance: AVNC (vertically) centers the output, causing a useless black bar at the top.

Would it be possible to align the output to the top instead of centering it? I wouldn't know why one would like to have it vertically centered. If it would be aligned to the top I could increase the vertical resolution.

Screenshot_20230224-074221

gujjwal00 commented 1 year ago

Hi @meeuw , you should be already be able to fit vertically by increasing vertical resolution (you may have to try few few times to get perfect fit).

meeuw commented 1 year ago

Ah sorry, I forgot to mention I'm deliberately not using my full vertical resolution because want to reserve space for the keyboard.

As you can see in the screenshot, if I increase the vertical resolution the scrollbar from chrome will overlap by the keyboard.

This is especially annoying for web applications like Slack which have a input field at the bottom. It's really hard to type that way (without visual feedback).

Screenshot_20230228-161042

gujjwal00 commented 1 year ago

Ah sorry, I forgot to mention I'm deliberately not using my full vertical resolution because want to reserve space for the keyboard.

As you can see in the screenshot, if I increase the vertical resolution the scrollbar from chrome will overlap by the keyboard.

This should not happen. AVNC will try to completely fill the available space if frame is larger than it.

meeuw commented 1 year ago

I'm using the currently latest version: 2.1.2

Yes, I have a cutout for the camera and the top bar matches it.

I think I found my troubles though. The Ctrl / Alt / Tab bar doesn't pushes the remote display viewer up like the virtual keyboard does.

Would this be possible to add? I'd also be fine if the remote display is always aligned to the top.

meeuw commented 1 year ago

I found out that when I disable fullscreen that works; thanks a lot for avnc. I'm a very happy user!

gujjwal00 commented 1 year ago

I think I found my troubles though. The Ctrl / Alt / Tab bar doesn't pushes the remote display viewer up like the virtual keyboard does.

If should push it up in latest version (which you are already using).

One issue might be that by default Android keeps the app bellow the cutout. So if you enable both Fullscreen & Draw behind display cutout settings, AVNC will be able to take advantage of entire screen area.