gujjwal00 / avnc

VNC Client for Android
GNU General Public License v3.0
660 stars 59 forks source link

Clipboard not syncing with TigerVNC 1.10.0 #157

Closed gujjwal00 closed 1 year ago

gujjwal00 commented 1 year ago

Originally posted by @Anonymous2716 in https://github.com/gujjwal00/avnc/issues/139#issuecomment-1467613593

@gujjwal00 on the latest version 2.2.0 the clipboard sync is not working can you confirm this? I'm using togervnc server version 1.10.1

It should work correctly. I have tested with TigerVNC 1.12, vino, TightVNC. Does tigervnc logs indicate something?

@gujjwal00 not really. Only error I for in the log is Xlib: extension "DPMS" missing on display ":1.0".

I wil try checking previous versions of avnc if they work then the issue with this version. If not then with the server.

I just checked with the v2.1 and clipboard syncing worked so with this version of avnc is the issue. I can't provide any logcats right now but I'm using it with termux. Maybe you can replicate from there if nor use other methods to find the issue.

gujjwal00 commented 1 year ago

@Anonymous2716 I tried with TigerVNC (v1.12) in Termux, and clipboard is working correctly for me. Can you try copying something after connecting to server. And make sure clipboard sharing is ON in AVNC settings.

@babaric-dev I think you have TigerVNC v1.10 in Termux. Have you encountered this issue?

Anonymous2716 commented 1 year ago

@gujjwal00 thanks. I wasn't sure if this issue is mine specific that's why I didn't open any New issues.

Can you try copying something after connecting to server. And make sure clipboard sharing is ON in AVNC settings.

His else would I copy? And yes clipboard sync is on by default. Is there any server side settings for this too ? Maybe config files.

Also where did you get vncserver v1.12 in termux? Its not available on the repo yet.

gujjwal00 commented 1 year ago

His else would I copy? And yes clipboard sync is on by default. Is there any server side settings for this too ? Maybe config files.

AVNC also syncs immediately after connecting, so I wanted to check if that is somehow a factor.

Also where did you get vncserver v1.12 in termux? Its not available on the repo yet.

I have Ubuntu 22.04 installed via proot-distro, with a very basic Xfce setup. TigerVNC was installed via apt. I don't use Termux regularly. I simply installed it to debug #105.

Anonymous2716 commented 1 year ago

I had Debian + ubuntu installed and it never synced any clipboard for me. Not avnc nor realvnc viewer. With xfce4-session & in the xstartup.

Since its proot I never bothered about the clipboard bcs a lot of things don't work there. Also I never encountered #105 . only when I switch back to the app it stays black screen for a second I guess its for decoding.

Also I was talking about termux natively. Here I have a basic xfce4 installation too.

gujjwal00 commented 1 year ago

I had Debian + ubuntu installed and it never synced any clipboard for me. Not avnc nor realvnc viewer

But you said AVNC v2.1 was working?

only when I switch back to the app it stays black screen for a second I guess its for decoding.

If the one-second delay started happening after AVNC v2.2, #156 might be the issue. Otherwise, its just normal.

Also I was talking about termux natively. Here I have a basic xfce4 installation too.

Do you have some notes on how to replicate your environment?

Anonymous2716 commented 1 year ago

But you said AVNC v2.1 was working?

With the native termux installation yes. And still does. Not proot environment.

No that delay happened before too. And I have to move around the pointer to display again. I'm not sure if this is an actual issue. I will look into #156 .

Yeah the same way you installed and setup xfce4 in Ubuntu.

Install tigervnc and xfce4 .

pkg install x11-repo

Then:

pkg install xfce4 tigervnc

And then write ~/.vnc/xstartup

Put

xfce4-session &

In the ~/.vnc/xstartup

Give it executable permission and there it is.

Write vncserver to start the server.

Tho i might do a clean installation and test just to be sure.

gujjwal00 commented 1 year ago

Thanks, I will try later today.

Anonymous2716 commented 1 year ago

I just noticed that its working one way. My phones clipboard can be pasted in the vnc environments clipboard but not the reverse.

gujjwal00 commented 1 year ago

I have found the bug. TigerVNC versions before 1.12 require explicit clipboard request from client (when extended clipboard is used). But LibVNCClient doesn't send the request currently.

Please try the following APK: app-debug.zip

Anonymous2716 commented 1 year ago

I've tried the apk. And I think it fixes the issue.

Also I remembered that most of the times I didn't use tigervnc but tightvnc server I used in proot. And I need to check my current xfce4 clipboard manager settings bcs whenever I select a text (not copy/cut) it also gets copied to the clipboard.

Even when I do sliding select whenever it gets copied on each character added to the string. Is this avnc or my clipboard?

Edit :

Even when I do sliding select whenever it gets copied on each character added to the string. Is this avnc or my clipboard?

This is got resolved by the settings . but whenever I select new text it does a double copy of it (copys twice , i know bcs gboard , openboard , florisboard etc has a clipboard listener and logs the each copied data and I use open board. ) without me clicking on the copy/cut. Can you confirm? And what is your clipboard manager settings set to?

gujjwal00 commented 1 year ago

The double-copy behavior is likely due to server. AVNC simply copies whatever server sends, however many times it sends.

but whenever I select new text it does a double copy of it (copys twice , i know bcs gboard , openboard , florisboard etc has a clipboard listener and logs the each copied data and I use open board. ) without me clicking on the copy/cut. Can you confirm?

X servers have multiple selections (primary: changed by selecting text; clipboard: changed by Ctrl+C/V). I think TigerVNC copies primary selection too, instead of just clipboard.

And what is your clipboard manager settings set to?

I am not sure which settings you are referring to. I don't use any special clipboard manager.

Anyway, this fix will be available in next version.

Anonymous2716 commented 1 year ago

@gujjwal00 thanks and if you have xfce4-goodies installed the application may pop up by the name "clipboard manager settings" in the application finder. Have a good day.