Feature Request: WOL - Githubissues

gujjwal00 / avnc

VNC Client for Android

GNU General Public License v3.0

660 stars 59 forks source link

Feature Request: WOL #218

Closed bcm314 closed 5 months ago

bcm314 commented 8 months ago

Would be nice to have implemented Wake On LAN.

In first step, maybe an extra button on each server would be ok (or simply always make WOL first and VNC-connection have to be manually retried).

The final step, I would suggest the following, when tapping on a server:

if no WOL is configured/enabled, behavior as it currently is
else (if WOL is configured/enabled), make a ping first
if received echo, behavior as it currently is
else (no echo) send WOL
wait n seconds (as server needs different time to boot, this value should be set for each server)
start VNC conection

masybe:

to be fastest (make n very low), VNC conection should be retried for maximum m seconds if VNC-server not yet ready.

also: could make pings in the server-list before, to show with green/red button the state of them.

gujjwal00 commented 8 months ago

IMO adding an extra button/menu item for servers is sufficient.

To use WOL, one would enable it in server options and provide target MAC address.
One configured, an entry will be added in the long-press menu for that server.
When clicked, AVNC will send the magic packet for that server.

To get feedback about when server finishes booting up, I would suggest using mDNS. AVNC already supports it and shows green indicator when a sever is reachable. On Linux, you can tell Avahi to automatically advertise a particular service on boot-up.

gujjwal00 commented 5 months ago

@bcm314 Can you try the following APK: https://github.com/gujjwal00/avnc/actions/runs/9338437912/artifacts/1560192543

You can add MAC address in Advanced server options. Then long-press on the server and send WoL packet.

bcm314 commented 5 months ago

Hi,

yes, it works very well - tested on two clients and with two different servers.

It's a little bit uncomfortable (using long-tap and many times tapping for reconnect), but I guess it's only the first test, right?

To remember: maybe an option in the server settings "always send WOL after short tap and do reconnect for x times"

gujjwal00 commented 5 months ago

Try this: https://github.com/gujjwal00/avnc/actions/runs/9354967090/artifacts/1563768652 It will automatically send WoL packet before connecting, and use the auto-reconnect feature to retry connection.

bcm314 commented 5 months ago

Works perfect!!!

gujjwal00 commented 5 months ago

v2.5 is available with WoL support. The UI is slightly updated: You need to first enable the Wake-on-LAN checkbox before entering MAC address.