search

gul-cpp / gul14

General Utility Library for C++14
https://gul14.info/
GNU Lesser General Public License v2.1
2 stars 1 forks source link

Fix Trigger wait tests #15

Closed alt-graph closed 2 years ago

alt-graph commented 2 years ago

This PR removes several "not-later-than" tests for Trigger::wait_for() and Trigger::wait_until().

Many Trigger-related tests fail on GitHub MacOS runners because the systems are under heavy contention. This sometimes leads to delays on the order of several tens of milliseconds, which is outside of the tolerance of the old delay tests.

Strictly speaking, there is no guarantee that Trigger's wait* functions wake up after any particular time span at all, so we should not test for that.

Drive-by-corrections include documentation and whitespace. :)

alt-graph commented 2 years ago

This fixes the last failing tests in the pipeline. Should we call it version 2.7 after this is merged?