search

gul-cpp / gul14

General Utility Library for C++14
https://gul14.info/
GNU Lesser General Public License v2.1
2 stars 1 forks source link

Fix compilation errors on Visual Studio #46

Closed alt-graph closed 1 year ago

alt-graph commented 1 year ago

Apparently some conditionally compiled blocks in variant.h were never tested on our usual Linux and Mac platforms. They contain undefined namespace references which blow up the build on Windows.

This PR fixes the bug by correcting some namespace qualifiers to "std::" and adding some library code from Michael Park's original variant implementation.

I'll try to come up with a CI setup for Windows builds on Github next.

Closes #45.

alt-graph commented 1 year ago

This PR fixes the Windows compilation errors, #47 adds a CI setup for Windows on Github.

alt-graph commented 1 year ago

Rebased on main.

alt-graph commented 1 year ago

Wonder what lib has been 🤔

lib is a namespace from one of Michael Park's original headers. It contains mainly metaprogramming helpers: https://github.com/mpark/variant/blob/master/include/mpark/lib.hpp