Closed alt-graph closed 8 months ago
For some reason the _v
versions are missing here?
For some reason the
_v
versions are missing here?
If I am not mistaken, the _v
versions are variable templates, and that language feature is missing from C++14.
Rebased on main.
If I am not mistaken, the
_v
versions are variable templates, and that language feature is missing from C++14.
Ah, its inline variables that is missing in C++14 that we would need, but yes. Variable templates are part of C++14.
Without inline it would fail if we use is_invocable_v
two times with identical parameters.
Adding a commit with some very very simple tests (that I used to find a is_invocable_v
formulation), maybe they are kind of how to use. Maybe just drop that commit.
@soerengrunewald
I believe the license in the RPM
spec is wrong; but I could not find out how multiple licenses are specified there.
Also the version is wrong (2.7
in RPM but 2.10
in reality) etc pp.
I would call RPMs unsupported. Maybe I should raise an error Issue.
This looks good. Feel free to drop the meaningless tests, but then maybe they just raise the test coverage and help sanitizer runs.
Oops, I think I just force-pushed over them. Sorry! I'll merge as-is, but maybe you can push the commit as a new PR?
Oops, I think I just force-pushed over them
git push --force-with-lease origin ...
protects you from over-force-pushing.
git push --force-with-lease origin ...
protects you from over-force-pushing.
Thanks, I did not know that. :+1:
git push --force-with-lease origin ...
protects you from over-force-pushing.Thanks, I did not know that. 👍
Just learned that yesterday :-D
So You Think You Know Git - FOSDEM 2024 (at 17:42)
This PR extracts the definitions of the C++17 backports of
from M. Park's variant header and makes them available in the public traits.h header in namespace gul14. The definitions are useful for GUL14 users in general, but we can also use them inside the library. This PR uses them to replace an ad-hoc implementation in our
expected
header, and they will be needed for theThreadPool
PR.