Include <functional> only when compiling under C++17 (was: invoke bug)

gul-cpp / gul14

General Utility Library for C++14

https://gul14.info/

GNU Lesser General Public License v2.1

2 stars 1 forks source link

Include <functional> only when compiling under C++17 (was: invoke bug) #74

Closed alt-graph closed 8 months ago

alt-graph commented 9 months ago

We use the definitions of invoke() etc. from the std:: namespace if the compiler supports C++17, but we forgot to include the <functional> header to actually make the declaration visible.

Closes #73

Finii commented 9 months ago

MacOS failing?

Finii commented 9 months ago

Scenario: Negative or zero times make sleep() not wait
       When: sleep(0ms) is executed
       Then: the elapsed time is very very small
-------------------------------------------------------------------------------
../tests/test_time_util.cc:88
...............................................................................

../tests/test_time_util.cc:90: FAILED:
  REQUIRE( toc(t0) < 0.001 )
with expansion:
  0.00130301 < 0.001

Ah MacOS problem will be solved by #76

Finii commented 9 months ago

MacOS failing?

Succeed after re-run. See other comment and Lars' other PR.

alt-graph commented 8 months ago

I propose to close this PR. IMO it only adds complexity without any major gain.

Finii commented 8 months ago

I still hope for GUL17, which already has a repo here.