search

gulp-community / gulp-concat

Streaming concat middleware for gulp
MIT License
792 stars 127 forks source link

Gulp concat seems to have issue with gulp sourcemaps #135

Closed sachinsingh-nodejs closed 7 years ago

sachinsingh-nodejs commented 7 years ago

I get following error when I use gulp sourcemaps with concat

Error: Invalid mapping: {"generated":{"line":1,"column":9},"source":"bootstrap/mixins/_clearfix.scss","original":{"line":14,"column":-7},"name":null} at SourceMapGenerator_validateMapping [as _validateMapping] (D:\POCs\RIC_Redesign\node_modules\source-map\lib\source-map-generator.js:277:13) at SourceMapGenerator_addMapping [as addMapping] (D:\POCs\RIC_Redesign\node_modules\source-map\lib\source-map-generator.js:101:12) at D:\POCs\RIC_Redesign\node_modules\concat-with-sourcemaps\index.js:60:28 at Array.forEach (native) at SourceMapConsumer_eachMapping [as eachMapping] (D:\POCs\RIC_Redesign\node_modules\source-map\lib\source-map-consumer.js:155:14) at Concat.add (D:\POCs\RIC_Redesign\node_modules\concat-with-sourcemaps\index.js:58:18) at DestroyableTransform.bufferContents [as _transform] (D:\POCs\RIC_Redesign\node_modules\gulp-concat\index.js:68:12) at DestroyableTransform.Transform._read (D:\POCs\RIC_Redesign\node_modules\readable-stream\lib_stream_transform.js:159:10) at DestroyableTransform.Transform._write (D:\POCs\RIC_Redesign\node_modules\readable-stream\lib_stream_transform.js:147:83) at doWrite (D:\POCs\RIC_Redesign\node_modules\readable-stream\lib_stream_writable.js:347:64) at writeOrBuffer (D:\POCs\RIC_Redesign\node_modules\readable-stream\lib_stream_writable.js:336:5) at DestroyableTransform.Writable.write (D:\POCs\RIC_Redesign\node_modules\readable-stream\lib_stream_writable.js:274:11) at DestroyableTransform.ondata (D:\POCs\RIC_Redesign\node_modules\readable-stream\lib_stream_readable.js:546:20) at emitOne (events.js:96:13) at DestroyableTransform.emit (events.js:188:7) at readableAddChunk (D:\POCs\RIC_Redesign\node_modules\readable-stream\lib_stream_readable.js:217:18)

yocontra commented 7 years ago

Can you provide a full code sample?

giosh94mhz commented 7 years ago

Same issue for me, but it seems not related to concat.

The bug is in libsass and confirmed in gulp-sass, but not fixed yet.

As a workaround, downgrade gulp-sass to ^2.3.2

mahnunchik commented 7 years ago

Any news?

yocontra commented 7 years ago

Bug is with another library (libsass) not gulp-concat so I'm going to close this. Needs to be fixed in libsass. If anyone has a problem not related to sass I will reopen.