search

gulp-community / gulp-concat

Streaming concat middleware for gulp
MIT License
792 stars 126 forks source link

gulp-concat seems to sallow errors #76

Closed ZachBray closed 8 years ago

ZachBray commented 9 years ago

Thank you for a very useful project!

I have an issue regarding errors not being propagated. Please consider the following snippet from my gulpfile:

    ...
    .on('error', function(err) {
        console.log("A!");
    })
    .pipe(concat('Sample.js'))
    .on('error', function (err) {
        console.log("B!");
    })
    ...

When there are any errors I see "A!" in the output. However, I do not see "B!" in the output (even if the first error handling section is omitted).

This means the exit code ends up being incorrect and this messes up my build integration.

yocontra commented 9 years ago

Node version?