search

gulp-community / gulp-concat

Streaming concat middleware for gulp
MIT License
792 stars 126 forks source link

Fails to concat when concat isn't the last item inside streamify #93

Closed Macil closed 9 years ago

Macil commented 9 years ago

If you look at https://github.com/AgentME/gulp-concat-bug-example, you'll see a gulpfile with two very similar tasks, "good" and "bad". As far as I can tell, they should work the same. They should browserify-bundle src/entry.js, use gulp-sourcemaps to parse the sourcemaps, prepend header.js into the stream and then concatenate it into the bundle, use gulpif to possibly minify it, write out the sourcemaps, and then write either good.js or bad.js into out/ depending on which task it was. The "bad" task wraps many of the streams in one call of streamify, "good" uses two streamify calls in an arbitrary way instead. The "bad" task fails to prepend header.js into bad.js.

The issue still appears with all of the sourcemaps stuff removed. I just left it there to show what I was trying to do originally.

Macil commented 9 years ago

I think this might be a bug with gulp-streamify or its documentation instead. I'm going to simplify the example and report it there.