Clone attributes from newest source file; option to skip concatenation if destination file exists and is newer than newest source

gulp-community / gulp-concat

Streaming concat middleware for gulp

MIT License

792 stars 127 forks source link

Clone attributes from newest source file; option to skip concatenation if destination file exists and is newer than newest source #97

Closed erikkemperman closed 9 years ago

erikkemperman commented 9 years ago

Issue 96

Clone attributes from newest source file instead of the first
Introduce an option to skip concatenation if destination file exists and is newer than newest source

Please note I took @contra 's comment to mean that skipping concatenation based on mtime should be the default behaviour... If that is not what we want just change line 27 in index.js.

yocontra commented 9 years ago

Not sure I understand the reasoning behind the second modification (skipping concatenation). I don't think that should be included.

erikkemperman commented 9 years ago

@contra Ah, all right, my bad. I must have misunderstood your earlier response to my comment about skipping the concatenation when none of the input files had changed, where you wrote that "I think that should be built into the plugin though, not something the user has to specify."

Anyway the first modification will work fine without the second.

yocontra commented 9 years ago

@erikkemperman Can you modify the PR or send a new one with just the first change?