search

gulp-community / gulp-favicons

gulp plugin for favicons
6 stars 3 forks source link

chore: upgrade to favicons v7 #26

Closed perrin4869 closed 1 year ago

perrin4869 commented 1 year ago

Does a few maintenance touches, but mainly adapts to the new stream API provided by favicons v7, which removed official support for gulp. The only thing necessary though was to replace the stream object with a Vinyl object instead. This requires a major version bump

rejas commented 1 year ago

Thanks for the PR. Would beside a major version bump be something necessary before releasing this (like readme update etc)?

perrin4869 commented 1 year ago

Right! I updated the README to reflect the fact the module will now be ESM only and removed the example options that don't seem to be available on favicons anymore (I did a cursory check on the latest master). I think that should be it :)