search

gulp-community / gulp-favicons

gulp plugin for favicons
6 stars 3 forks source link

Border added around favicons #7

Closed belbasaur closed 3 years ago

belbasaur commented 5 years ago

Hi,

I've noticed lately that a faint dark border is being added around favicons. Is this an option I can change somewhere or a bug?

Currently, as a workaround, I'm using an older version (2.2.5). I'm aware this is quite an old version, but I'm not quite sure at what version this started happening.

Please see an example of what it looks like in Chrome in the screenshot: Screen Shot 2019-07-31 at 4 18 21 pm

Please let me know if you need more clarification.

rejas commented 5 years ago

hi @belbasaur I have to admit, I cannot really see borders around there but that might just be my monitors fault :-) Anyway, have you tried to make your icons with the favicons package directly from gulp? See https://github.com/itgalaxy/favicons#gulp for instructions. Since this plugin is just a thin wrapper around the favicons package, most icon issues are directly to be fixed in there

belbasaur commented 5 years ago

Hi @rejas, thanks for your response. Yes, that is how we do it :)

This is more noticeable with light coloured favicons. I have attached another example of a favicon with the added outline if you're interested. It is very subtle but very noticeable in light coloured browser tabs.

favicon

If you aren't aware of this then I'm assuming there isn't something I can do about it at the moment.

Cheers

rejas commented 5 years ago

hi @belbasaur you might have misunderstood me so I rephrase my question: how do you call the plugin? could you post your gulp code?

rejas commented 3 years ago

Closing due to inactivity